> Hello,
>
> Can you give examples what you are fixing?
changes in line 8-12:
If you try to download verses for example from "1 Samuel" => "NiV 2010" from
Biblegateway it fails because the book name was twice encoded. First from
urllib.quote and then from urllib.urlencode.
urlencode doesn't work for all unicode names like arabic or chinese (it comes
with ascii out of range errors in these cases). That's why I choose the way to
use urllib.quote and drop urlencode.
changes in line 20-21:
If you try to download "1 Samuel" Chapter 11 in "NiV 2010" it was failing with
the following error in trunk:
Traceback (most recent call last):
File "openlp/plugins/bibles/lib/mediaitem.py", line 630, in
onQuickSearchButton
self.search_results = self.plugin.manager.get_verses(bible, text)
File "openlp/plugins/bibles/lib/manager.py", line 308, in get_verses
return self.db_cache[bible].get_verses(reflist, show_error)
File "openlp/plugins/bibles/lib/http.py", line 478, in get_verses
search_results = self.get_chapter(book, reference[1])
File "openlp/plugins/bibles/lib/http.py", line 507, in get_chapter
return handler.get_bible_chapter(self.download_name, book, chapter)
File "openlp/plugins/bibles/lib/http.py", line 100, in get_bible_chapter
verse_list[1] = unicode(first_verse.contents[0])
IndexError: list index out of range
--
https://code.launchpad.net/~orangeshirt/openlp/bibles_fixes/+merge/62947
Your team OpenLP Core is subscribed to branch lp:openlp.
_______________________________________________
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openlp-core
More help : https://help.launchpad.net/ListHelp
