Review: Needs Fixing Responding to you comments but not reviewing the code.
Possible usage is no reason to put things in now. Put them in when they are needed. If code cannot be run please remove it so we can see and test what is going to be implemented. The new dialog is case here. Same with the Flash stuff. move media_api.py I am not happy with api as a name for a variable. Phonon is an abstraction layer but so is vlc. API in the terms of a variable name is meaningless. Please can you make sure changes and head merges are in separate commits as per Andrea's comment. -- https://code.launchpad.net/~crichter/openlp/media_rewrite/+merge/81110 Your team OpenLP Core is subscribed to branch lp:openlp. _______________________________________________ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
