The proposal to merge lp:~googol/openlp/bug-768495 into lp:openlp has been updated.
Description changed to: Hello, Fixed bug 768495 (Shortcut can be assigned twice in certain circumstances) Description of the fix: 1) Create a dict with the shortcuts as keys and a list of actions using this shortcut as value. 2) When we add a new action/shortcut we check if the shortcut is valid. If this is the case we add it to the dict and if not we remove the shortcut. Possible space for improvements: - notify the user that a shortcut has been disabled - make sure that shortcuts with lower priority are disabled if there should be a conflict (currently we remove the shortcut from the last actions) How to test this? 1) Assign "R" to the "Re-index tool" action 2) Disable the songs plugin 3) Assign "R" to another action 4) Enable the songs plugin For more details, see: https://code.launchpad.net/~googol/openlp/bug-768495/+merge/84372 -- https://code.launchpad.net/~googol/openlp/bug-768495/+merge/84372 Your team OpenLP Core is requested to review the proposed merge of lp:~googol/openlp/bug-768495 into lp:openlp. _______________________________________________ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
