Review: Needs Fixing 1) It should be except (etree.XMLSyntaxError, AttributeError):
2) Do not do this. This is too dangerous.... Any AttributeError in xml_to_song will be caught. Better make sure that the exception is caught in xml_to_song instead. -- https://code.launchpad.net/~mahfiaz/openlp/bug-304/+merge/85787 Your team OpenLP Core is subscribed to branch lp:openlp. _______________________________________________ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp