Right. In fact there is basically no difference between Qt and urllib. The only 
one is, that Qt returns its byte string as QByteArray while Python returns the 
byte string as str type.
For the sake of clarity, it is a good idea to avoid assigning different 
variable types to the same variable.
Ah well, and urllib is a Python Standard Library and still used in OpenLP. So 
this introduces no additional dependencies nor makes any differences at run 
time. 

Your code does completely fine. This comment was more some hint, how you could 
improve the style slightly.
-- 
https://code.launchpad.net/~mahfiaz/openlp/bug-860876/+merge/85758
Your team OpenLP Core is subscribed to branch lp:openlp.

_______________________________________________
Mailing list: https://launchpad.net/~openlp-core
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~openlp-core
More help   : https://help.launchpad.net/ListHelp

Reply via email to