Review: Needs Fixing Line 97 should be capitals in parse method variables should be more meaningful in their name and correct. byte is a character! Strip_rtf should these not be unicode strings? Strip_rtf should these not be constants as this is called in a loop? Is the decode function correct? if it fails it gets the encoding but does not try again! -- https://code.launchpad.net/~mahfiaz/openlp/bug-933706/+merge/111162 Your team OpenLP Core is subscribed to branch lp:openlp.
_______________________________________________ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
