Review: Needs Fixing
Please use words_with_underscore as variables/attributes (we are currently
converting our code to this)
Don't do this: if subSearch : search_results =
self.constrainSearch(search_results)
Do this:
if sub_search:
search_results = self.constrainSearch(search_results)
Your method does not have a docstring.
constrainSearch(self, first_parameter, second_parameter):
""""
bla bla bla
``first_parameter``
First parameter description
``second_parameter``
.....
"""
95 + testset = set(self.searchResults)
96 + res = [x for x in search_results if x in testset]
97 + return res
Please use proper names: result = [search_result for search_result in
search_results if search_result in testset]
Or even something better....
:)
--
https://code.launchpad.net/~martin-hosken/openlp/subsearch/+merge/152301
Your team OpenLP Core is subscribed to branch lp:openlp.
_______________________________________________
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openlp-core
More help : https://help.launchpad.net/ListHelp
