Review: Needs Fixing Much better but Have issue with 104-110 please see previous comment. You are exposing the internals of a ServiceItem to a plugin and that should be bad practice.
The rest looks good to me though. -- https://code.launchpad.net/~marmyshev/openlp/item_title/+merge/158653 Your team OpenLP Core is subscribed to branch lp:openlp. _______________________________________________ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp