Out of order replies: DB tests are dependent on previous DB tests. Nose rearranges tests based on alphabet sorting. Already tried this and most tests failed.
Projector.ip 100chars - Possible upgrade may allow host name rather than IP, so made allowances for FQDN. projectorconstants.py and networkutils.py are in a separate file rather than __init__ since several of the local files need to import them. I believe the standard is import from a module but not from __init__ inside same module group. Correct me if I'm wrong or can help with recursive imports please. families, protocols, __get_constants, __get_names removed - holdover from using python sockets rather than pyqt sockets. Blank lines fixed. Used to help me keep track of what I was doing. Wizard class methods comments fixed. Do __init__() entries need comments? Will look at OpenLPMixin class later. and did you mean ProjectorDB class? (Projector class is db table.) Assert text updated - hope they're now corret. Other than QtValidator, IP validation should be able to be used. I noticed that Remotes plugin only allows IPv4 with no option for IPv6, so would take some rework. Also, would Remotes plugin want option of allowing FQDN? -- https://code.launchpad.net/~alisonken1/openlp/openlp-2.1-projector/+merge/235050 Your team OpenLP Core is subscribed to branch lp:openlp. _______________________________________________ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
