Review: Needs Fixing
Diff comments:
>
> === modified file 'openlp/core/ui/advancedtab.py'
> --- openlp/core/ui/advancedtab.py 2015-01-18 13:39:21 +0000
> +++ openlp/core/ui/advancedtab.py 2015-11-02 20:59:26 +0000
> @@ -349,6 +354,8 @@
> self.default_color = settings.value('default color')
> self.default_file_edit.setText(settings.value('default image'))
> self.slide_limits = settings.value('slide limits')
> + self.search_as_you_type = settings.value('search as type')
whoops, we missed this one... "self.is_search_as_you_type_enabled"
> + self.search_as_type_check_box.setChecked(self.search_as_you_type)
> # Prevent the dialog displayed by the alternate_rows_check_box to
> display.
> self.alternate_rows_check_box.blockSignals(True)
> self.alternate_rows_check_box.setChecked(settings.value('alternate
> rows'))
> @@ -424,8 +431,14 @@
> settings.setValue('x11 bypass wm',
> self.x11_bypass_check_box.isChecked())
> self.settings_form.register_post_process('config_screen_changed')
>
> self.settings_form.register_post_process('slidecontroller_update_slide_limits')
> + settings.setValue('search as type', self.search_as_you_type)
> settings.endGroup()
>
> + def on_search_as_type_check_box_changed(self, check_state):
> + self.search_as_you_type = (check_state == QtCore.Qt.Checked)
whoops, we missed this one... "self.is_search_as_you_type_enabled"
> + self.settings_form.register_post_process('songs_config_updated')
> + self.settings_form.register_post_process('custom_config_updated')
> +
> def cancel(self):
> """
> Dialogue was cancelled, remove any pending data path change.
--
https://code.launchpad.net/~trb143/openlp/bugs-2_4b/+merge/276463
Your team OpenLP Core is subscribed to branch lp:openlp.
_______________________________________________
Mailing list: https://launchpad.net/~openlp-core
Post to : [email protected]
Unsubscribe : https://launchpad.net/~openlp-core
More help : https://help.launchpad.net/ListHelp
