Review: Needs Information All good, would just prefer except <SomeTypeOfExceptionHere> over a catch-all except statement.
Diff comments: > > === modified file 'openlp/plugins/bibles/lib/mediaitem.py' > --- openlp/plugins/bibles/lib/mediaitem.py 2016-01-08 17:44:47 +0000 > +++ openlp/plugins/bibles/lib/mediaitem.py 2016-03-29 20:56:29 +0000 > @@ -764,6 +764,9 @@ > except IndexError: > log.exception('The second_search_results does not have > as many verses as the search_results.') > break > + except: This is a very wide catching exception. Is there a way to narrow it down a bit? > + log.exception('The second_search_results does not have > this book.') > + break > bible_text = '%s %d%s%d (%s, %s)' % (book, verse.chapter, > verse_separator, verse.verse, version, > second_version) > else: -- https://code.launchpad.net/~tomasgroth/openlp/25bugfixes2/+merge/290370 Your team OpenLP Core is subscribed to branch lp:openlp. _______________________________________________ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp