Review: Needs Fixing A question in the code
In future can you put the test results at the bottom of the request as it makes the history easier to read. Diff comments: > > === modified file 'openlp/core/projectors/manager.py' > --- openlp/core/projectors/manager.py 2018-04-20 06:04:43 +0000 > +++ openlp/core/projectors/manager.py 2018-04-28 02:41:38 +0000 > @@ -513,6 +519,18 @@ > > projector.socket_timer.timeout.disconnect(projector.link.socket_abort) > except (AttributeError, TypeError): > pass > + # Disconnect signals from projector being deleted > + try: > + self.pjlink_udp.data_received.disconnect(projector.get_buffer) What about other errors. Should they not be handled more gracefully. > + except (AttributeError, TypeError): > + pass > + try: > + if self.pjlink_udp[projector.port]: > + > self.pjlink_udp[projector.port].data_received.disconnect(projector.get_buffer) > + except (AttributeError, TypeError): > + pass > + > + # Rebuild projector list > new_list = [] > for item in self.projector_list: > if item.link.db_item.id == projector.link.db_item.id: -- https://code.launchpad.net/~alisonken1/openlp/pjlink2-r/+merge/344795 Your team OpenLP Core is subscribed to branch lp:openlp. _______________________________________________ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
