Review: Approve
Diff comments: > > === modified file 'openlp/core/common/i18n.py' > --- openlp/core/common/i18n.py 2019-06-28 18:09:25 +0000 > +++ openlp/core/common/i18n.py 2019-07-18 19:27:49 +0000 > @@ -338,8 +338,8 @@ > Override the default object creation method to return a single > instance. > """ > if not cls.__instance__: > - cls.__instance__ = object.__new__(cls) > - cls.load(cls) > + cls.__instance__ = super().__new__(cls) > + cls.__instance__.load() According to the Python documentation: Typical implementations create a new instance of the class by invoking the superclass’s __new__() method using super().__new__(cls[, ...]) with appropriate arguments and then modifying the newly-created instance as necessary before returning it. > return cls.__instance__ > > def load(self): -- https://code.launchpad.net/~phill-ridout/openlp/fixes-III/+merge/370337 Your team OpenLP Core is subscribed to branch lp:openlp. _______________________________________________ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
