[
https://issues.apache.org/jira/browse/OPENMEETINGS-194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259484#comment-13259484
]
Maxim Solodovnik commented on OPENMEETINGS-194:
-----------------------------------------------
Thanks :)
another portion of criticism :) :
1) boolean force = cmdl.hasOption("force") ? true : false; is equivalent to
boolean force = cmdl.hasOption("force");
2) connectionProperties.setDriverName("org.apache.derby.jdbc.ClientDriver"); --
IMHO driver name should not be hardcoded (for example there is 2 drivers for
Oracle and user might set 1 of them manually)
this is my last correction, i promise :)
> Command line admin: added parameter "--drop", to drop database before install
> -----------------------------------------------------------------------------
>
> Key: OPENMEETINGS-194
> URL: https://issues.apache.org/jira/browse/OPENMEETINGS-194
> Project: Openmeetings
> Issue Type: Improvement
> Reporter: Dmitry Zamula
> Assignee: Maxim Solodovnik
> Priority: Minor
> Labels: cli, install, patch
> Attachments: openmeetings_cli_install_drop_db.patch,
> openmeetings_cli_install_drop_db_version2.patch
>
>
> Optional parameter "--drop" allows to drop existing database before
> Openmeetings install.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
