Hi Maxim, I have removed the unnecessary comments and have created the helper function to construct the URL as you had said. About using an array and using a for loop after that, I am working on it and will submit the patch tomorrow.
On Tue, Aug 7, 2012 at 12:54 PM, Maxim Solodovnik <[email protected]>wrote: > Hello Ankur, > > Were you able to clean up your code based on my last review)? > Is the code ready for the next review? > > On Sun, Aug 5, 2012 at 12:44 PM, Ankur Ankan <[email protected]> wrote: > > > Hi, > > > > I have committed the code to jira and the plugin is working fine but I > > think I still need to work on it's looks. > > > > And the test server is not accessible. Is the server down?? > > > > On Thu, Aug 2, 2012 at 7:23 PM, [email protected] < > > [email protected] > > > wrote: > > > > > Ok! > > > > > > Eugen would you like to act as Release Manager for the SugarCRM plugin > > > or do you want me to do it? > > > > > > Sebastian > > > > > > 2012/8/2 Eugen Schwert <[email protected]>: > > > > @Sebastian the SugarCRM artefacts are okay. > > > > > > > > 2012/8/2 [email protected] <[email protected]>: > > > >> @Ankur That is fine, do you have a demo space available for testing? > > > >> @Josh: I will send you some user that has access to the SOAP/REST > API > > > >> of demo.openmeetings.de so you can test. > > > >> For the general "openmeetings_gateway.php" you might simply compare > > > >> the gateway's of all plugins to see which they have in common. It > > > >> should be almost identical. > > > >> > > > >> @Eugen: Can you please check if the following artefcts are okay: > > > >> > > > > > > https://builds.apache.org/view/M-R/view/OpenMeetings/job/OpenMeetings%20SugarCRM%20Plugin/ > > > >> > > > >> and please also complete the Changelog: > > > >> > > > > > > https://svn.apache.org/repos/asf/incubator/openmeetings/trunk/plugins/sugarcrm/6.x.x/CHANGELOG > > > >> > > > >> Thanks! > > > >> Sebastian > > > >> > > > >> 2012/8/2 Ankur Ankan <[email protected]>: > > > >>> I need a two days more. > > > >>> On Aug 2, 2012 9:08 AM, "Josh Dolitsky" <[email protected]> > wrote: > > > >>> > > > >>>> Also, I've recently been looking at how to create Google Chrome > > > plugins, is > > > >>>> there perhaps something cool we could do with a plug-in? Too much? > > > >>>> > > > >>>> Josh > > > >>>> > > > >>>> On Wed, Aug 1, 2012 at 11:35 PM, Josh Dolitsky < > [email protected] > > > > > > >>>> wrote: > > > >>>> > > > >>>> > @Sebastian I've just started playing with the demo space, but > have > > > an > > > >>>> > issue (see screenshot). First, should I be using > > > >>>> > http://demo.openmeetings.de/openmeetings as the OM installation > > > path? > > > >>>> > Also, if this is the case, I will need an admin account to > create > > > new > > > >>>> > rooms, right? Should I just set to localhost? > > > >>>> > > > > >>>> > Also, I would be very interested in helping with the PHP gateway > > to > > > make > > > >>>> > it extensible for future REST integrations. > > > >>>> > > > > >>>> > Josh > > > >>>> > > > > >>>> > > > > >>>> > On Wed, Aug 1, 2012 at 2:24 PM, [email protected] < > > > >>>> > [email protected]> wrote: > > > >>>> > > > > >>>> >> @Maxim yes that would be great! > > > >>>> >> > > > >>>> >> Sebastian > > > >>>> >> > > > >>>> >> 2012/8/1 Maxim Solodovnik <[email protected]>: > > > >>>> >> > I'll create build file with rat task. > > > >>>> >> > Additionally I think it would be good to have > > > openmeetings_gateway as > > > >>>> >> > separate project shared with all php projects (as future task > > > :)) ) > > > >>>> >> > > > > >>>> >> > On Wed, Aug 1, 2012 at 9:00 PM, [email protected] < > > > >>>> >> [email protected] > > > >>>> >> >> wrote: > > > >>>> >> > > > > >>>> >> >> Hi Maxim, > > > >>>> >> >> > > > >>>> >> >> which packages need to be created from the source to create > a > > > Joomla > > > >>>> >> >> Plugin? > > > >>>> >> >> Is it only one component and one module or are there more > and > > > what > > > >>>> >> >> naming conventions need to be applied? > > > >>>> >> >> > > > >>>> >> >> I've created a build script for the Moodle plugin: > > > >>>> >> >> > > > >>>> >> >> > > > >>>> >> > > > >>>> > > > > > > https://svn.apache.org/repos/asf/incubator/openmeetings/trunk/plugins/moodle_plugin/build.xml > > > >>>> >> >> It should be easy to recfator the build script to produce > > > similar > > > >>>> >> >> packages for the Joomla Plugin. > > > >>>> >> >> > > > >>>> >> >> Thanks! > > > >>>> >> >> Sebastian > > > >>>> >> >> > > > >>>> >> >> 2012/8/1 Maxim Solodovnik <[email protected]>: > > > >>>> >> >> > Joomla plugin need to be tested. > > > >>>> >> >> > I was hoping on users feedback. > > > >>>> >> >> > The code should be clean. All files should have license > > > headers. > > > >>>> >> Need to > > > >>>> >> >> > run rat on it > > > >>>> >> >> > On Aug 1, 2012 6:23 PM, "[email protected]" < > > > >>>> >> [email protected]> > > > >>>> >> >> > wrote: > > > >>>> >> >> > > > > >>>> >> >> >> I have configured and update the Moodle plugin on > Jenkins: > > > >>>> >> >> >> > > > https://builds.apache.org/job/OpenMeetings%20Moodle%20Plugin/ > > > >>>> >> >> >> > > > >>>> >> >> >> @Maxim: What is the status of the Joomla plugin, is it > > ready > > > to > > > >>>> >> release? > > > >>>> >> >> >> @Eugen: What is the status of the SugarCRM plugin, is it > > > ready to > > > >>>> >> >> release? > > > >>>> >> >> >> @German/Alexei: Teambox/Jitsi should be released as > plugin? > > > >>>> >> >> >> @Josh: ATutor? > > > >>>> >> >> >> @Ankur: Zimbra? > > > >>>> >> >> >> > > > >>>> >> >> >> Thanks! > > > >>>> >> >> >> Sebastian > > > >>>> >> >> >> -- > > > >>>> >> >> >> Sebastian Wagner > > > >>>> >> >> >> https://twitter.com/#!/dead_lock > > > >>>> >> >> >> http://www.openmeetings.de > > > >>>> >> >> >> http://www.webbase-design.de > > > >>>> >> >> >> http://www.wagner-sebastian.com > > > >>>> >> >> >> [email protected] > > > >>>> >> >> >> > > > >>>> >> >> > > > >>>> >> >> > > > >>>> >> >> > > > >>>> >> >> -- > > > >>>> >> >> Sebastian Wagner > > > >>>> >> >> https://twitter.com/#!/dead_lock > > > >>>> >> >> http://www.openmeetings.de > > > >>>> >> >> http://www.webbase-design.de > > > >>>> >> >> http://www.wagner-sebastian.com > > > >>>> >> >> [email protected] > > > >>>> >> >> > > > >>>> >> > > > > >>>> >> > > > > >>>> >> > > > > >>>> >> > -- > > > >>>> >> > WBR > > > >>>> >> > Maxim aka solomax > > > >>>> >> > > > >>>> >> > > > >>>> >> > > > >>>> >> -- > > > >>>> >> Sebastian Wagner > > > >>>> >> https://twitter.com/#!/dead_lock > > > >>>> >> http://www.openmeetings.de > > > >>>> >> http://www.webbase-design.de > > > >>>> >> http://www.wagner-sebastian.com > > > >>>> >> [email protected] > > > >>>> >> > > > >>>> > > > > >>>> > > > > >>>> > > > >> > > > >> > > > >> > > > >> -- > > > >> Sebastian Wagner > > > >> https://twitter.com/#!/dead_lock > > > >> http://www.openmeetings.de > > > >> http://www.webbase-design.de > > > >> http://www.wagner-sebastian.com > > > >> [email protected] > > > > > > > > > > > > -- > > > Sebastian Wagner > > > https://twitter.com/#!/dead_lock > > > http://www.openmeetings.de > > > http://www.webbase-design.de > > > http://www.wagner-sebastian.com > > > [email protected] > > > > > > > > > -- > WBR > Maxim aka solomax >
