I rather prefer smaller packages with not so many classes.
There will be additionally BackupPanel and ConnectionsPanel in the
admin area. It is likely that we have around 20 classes in that
package then. From my point of view, if you have more then 10 classes
in a package you should start thinking about how to group them into
sub-packages.

Sebastian

2012/9/13 Maxim Solodovnik <[email protected]>:
> Hello Sebastian,
>
> I saw "entityesPerPage does not really work yet" I did checkin it incomplete
> (hopefully will find time and will fix it asap).
>
> I did move LangPanel* to
> org.apache.openmeetings.web.components.admin.labels, BUT I think 2-3 classes
> per package is wasting of packages.
> All classes belongs to admin and have self-descriptive name I would vote for
> moving it to org.apache.openmeetings.web.components.admin (with no
> subpackages).
>
> What do you think?
>
> I'll add search to the table header.
>
> On Thu, Sep 13, 2012 at 1:11 AM, [email protected]
> <[email protected]> wrote:
>>
>> Hi Maxim,
>>
>> I've seen your work with the admin form and the drop down box for the
>> number of records shown in the table/list. That looks interesting :)
>> But the entityesPerPage does not really work yet. If you choose
>> another item, for example 10 or 25 in the language editor, it does
>> load something but it does not change the number of records shown. I
>> guess there is missing something to notify the
>>
>> I have a request for the "lang" package, I think it might makes sense
>> if you could move it to: org.apache.web.components.admin.* instead of
>> org.apache.web.components.*. And maybe it might makes sense to rename
>> the package to "labels" instead of "lang".
>>
>> And I would propose to add a search field in the header of each table
>> and integrate that into the standard fields. Either into
>> PagedEntityListPanel or in some new super/child class of it that also
>> extends AdminPanel.
>>
>> What do you think?
>>
>> Thanks!
>> Sebastian
>> --
>> Sebastian Wagner
>> https://twitter.com/#!/dead_lock
>> http://www.webbase-design.de
>> http://www.wagner-sebastian.com
>> [email protected]
>
>
>
>
> --
> WBR
> Maxim aka solomax



-- 
Sebastian Wagner
https://twitter.com/#!/dead_lock
http://www.webbase-design.de
http://www.wagner-sebastian.com
[email protected]

Reply via email to