I feel this code need to be redesigned :( I don't really like publicSID stored in 2 places ... too much space for the error :( => well actually this is exactly what I am doing no, refactor in order to have the publicSID in two places. One time in the database/sessionstore second time in the IClient. If you don't have the information in the IClient you need to access the full Client-object, which would mean that you need to make a request to the database. Accessing db objects during sync methods will destroy our performance.
Sebastian 2013/1/24 Maxim Solodovnik <[email protected]> > Thanks for the update. > I did check all the places publicSID is get changed and seems to fix them > all. > > I feel this code need to be redesigned :( I don't really like publicSID > stored in 2 places ... too much space for the error :( > > > On Thu, Jan 24, 2013 at 3:20 AM, [email protected] < > [email protected]> wrote: > >> What you've fixed Maxim was the method: >> public synchronized Boolean overwritePublicSID(String newPublicSID) >> right? >> That seems to me correct. I am currently not 100% sure if there is >> another method to be checked. >> But there is an easy way to check it: >> When you goto the RoomClient object, highlight the method "setPublicSID" >> and then press shift+ctrl+g then it should show all code snippets that >> reference this method ... aka everywhere where the publicSID is set to the >> RoomClient. >> And everywhere this publicSID is set, also the IClient needs to be >> updated using the SessionsVariablesUtil. >> I think I missed this step for this session attribute. >> >> Sebastian >> >> >> >> 2013/1/22 [email protected] <[email protected]> >> >> Hi Maxim, >>> >>> I will try to look at it asap. I did not expect any issue, I thought it >>> should have been working just as it did before I added the cluster specific >>> stuff. >>> >>> Sebastian >>> >>> 2013/1/22 Maxim Solodovnik <[email protected]> >>> >>>> Can you please take a look at >>>> https://issues.apache.org/jira/browse/OPENMEETINGS-512 and my fix for >>>> it? >>>> >>>> >>>> On Tue, Jan 22, 2013 at 11:26 AM, [email protected] < >>>> [email protected]> wrote: >>>> >>>>> I see currently two main things: >>>>> - getting all changes done needed for the clustering + test them >>>>> - create backups of current and previous OpenMeetings versions and >>>>> import them (it would be great if the import could be automized using a >>>>> JUnit test, so that with any future change when can simply run the test >>>>> suite and will see if any backup fails to import) >>>>> >>>>> Sebastian >>>>> >>>>> >>>>> 2013/1/22 George Kirkham <[email protected]> >>>>> >>>>>> *Please consider:* One feature to include in 2.1 would be enabling >>>>>> Adobe’s Acoustic Echo Cancelling (AEC).**** >>>>>> >>>>>> ** ** >>>>>> >>>>>> We have tested this, and it greatly improves end user experience for >>>>>> meetings (for people whose computers do not support hardware AEC).*** >>>>>> * >>>>>> >>>>>> ** ** >>>>>> >>>>>> Thanks,**** >>>>>> >>>>>> ** ** >>>>>> >>>>>> George Kirkham**** >>>>>> >>>>>> ** ** >>>>>> >>>>>> ** ** >>>>>> >>>>>> ** ** >>>>>> >>>>>> *From:* [email protected] [mailto:[email protected]] >>>>>> *Sent:* Tuesday, 22 January 2013 8:24 AM >>>>>> *To:* [email protected] >>>>>> *Subject:* Re: some questions to recordings and different >>>>>> moodle-sites**** >>>>>> >>>>>> ** ** >>>>>> >>>>>> Regarding releasing, I think a first step towards that would be to >>>>>> decide on a release manager and about the features that need to be >>>>>> completed for 2.1. I guess we all have a rough idea about what should go >>>>>> into v2.1 but no concrete consens was made yet IMHO.**** >>>>>> >>>>>> Sebastian**** >>>>>> >>>>>> ** ** >>>>>> >>>>>> 2013/1/22 Maxim Solodovnik <[email protected]>**** >>>>>> >>>>>> lots of questions :)**** >>>>>> >>>>>> ** ** >>>>>> >>>>>> 1) openmeetingsModuleKey should be used to separate users/files of >>>>>> multiple CMS connected to one openmeetings (multiple moodles in your >>>>>> case) >>>>>> **** >>>>>> >>>>>> 2) sure you can manage the recordings it is located at >>>>>> OM_HOME/webapps/openmeetings/streams/hibernate/**** >>>>>> >>>>>> 3) The id in the streams folder id DB id of the recording**** >>>>>> >>>>>> 4) openmeetingsModuleKey acts as "external user type" this is by >>>>>> design made to separate users from multiple CMSes**** >>>>>> >>>>>> 5) this part is tricky, you can use OM system export/import, but in >>>>>> your case this will create dublicate users/groups/rooms (most probably) >>>>>> and >>>>>> there is no "automatic way" to handle this mess.**** >>>>>> >>>>>> ** ** >>>>>> >>>>>> I hope we will have release soon, but this question is for Sebastian* >>>>>> *** >>>>>> >>>>>> ** ** >>>>>> >>>>>> On Mon, Jan 21, 2013 at 10:08 PM, <[email protected]> wrote:** >>>>>> ** >>>>>> >>>>>> Hello, >>>>>> >>>>>> I've some questions about openmeetings in connection with different >>>>>> moodle-installations. I have installations of openmeetings (1.8, 1.9 >>>>>> and >>>>>> 2.0) for different moodle-sites. Particularly I am interested in how >>>>>> to >>>>>> manage conference-recordings of openmeetings. The goal is to have one >>>>>> openmeetings installation (2.+) for different moodle-sites. My >>>>>> specific >>>>>> questions are: >>>>>> >>>>>> 1. What can I do, to see as an moodle-teacher only the recordings I've >>>>>> made? The openmeetingsModuleKey seems to have no effect. >>>>>> 2. How are the recordings playable offline? Is it possible to manage >>>>>> (to >>>>>> export or to delete) these recordings directly with in openmeetings? >>>>>> 3. How or where can I find the recordings? What means in that case >>>>>> the ID >>>>>> in the ./streams folder? >>>>>> 4. Can moodle users and moodle courses be assigned to certain >>>>>> organizations by the webservice? How can the user groups from various >>>>>> moodle systems be managed in openmeetings? >>>>>> 5. How can I migrate (export and import) recordings from old existing >>>>>> openmeetings installations (1.8 and 1.9) to a new clean 2.0 >>>>>> openmeetings >>>>>> installation? >>>>>> >>>>>> And last but not least: >>>>>> When will the next version of openmeetings (2.1) expected? >>>>>> >>>>>> Thank you for your help, >>>>>> Michael**** >>>>>> >>>>>> >>>>>> >>>>>> **** >>>>>> >>>>>> ** ** >>>>>> >>>>>> -- >>>>>> WBR >>>>>> Maxim aka solomax **** >>>>>> >>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Sebastian Wagner >>>>>> https://twitter.com/#!/dead_lock >>>>>> http://www.webbase-design.de >>>>>> http://www.wagner-sebastian.com >>>>>> [email protected] **** >>>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> Sebastian Wagner >>>>> https://twitter.com/#!/dead_lock >>>>> http://www.webbase-design.de >>>>> http://www.wagner-sebastian.com >>>>> [email protected] >>>>> >>>> >>>> >>>> >>>> -- >>>> WBR >>>> Maxim aka solomax >>>> >>> >>> >>> >>> -- >>> Sebastian Wagner >>> https://twitter.com/#!/dead_lock >>> http://www.webbase-design.de >>> http://www.wagner-sebastian.com >>> [email protected] >>> >> >> >> >> -- >> Sebastian Wagner >> https://twitter.com/#!/dead_lock >> http://www.webbase-design.de >> http://www.wagner-sebastian.com >> [email protected] >> > > > > -- > WBR > Maxim aka solomax > -- Sebastian Wagner https://twitter.com/#!/dead_lock http://www.webbase-design.de http://www.wagner-sebastian.com [email protected]
