this might be another candidate for merging
-- 
- Harald Welte <[EMAIL PROTECTED]>                      http://openmoko.org/
============================================================================
Software for the world's first truly open Free Software mobile phone
--- Begin Message ---
From: Matt Reimer <[EMAIL PROTECTED]>

If there were multiple bit errors in the data s3c2410_nand_correct_data()
was returning 0 (no error) instead of -EBADMSG, so the upper layers
(like JFFS2) would not know the data is corrupt.

Signed-off-by: Matt Reimer <[EMAIL PROTECTED]>
---
 drivers/mtd/nand/s3c2410.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/mtd/nand/s3c2410.c b/drivers/mtd/nand/s3c2410.c
index 077fdcc..1aa3a18 100644
--- a/drivers/mtd/nand/s3c2410.c
+++ b/drivers/mtd/nand/s3c2410.c
@@ -397,7 +397,7 @@ static int s3c2410_nand_correct_data(struct mtd_info *mtd, 
u_char *dat,
        if ((diff0 & ~(1<<fls(diff0))) == 0)
                return 1;
 
-       return 0;
+       return -EBADMSG;
 }
 
 /* ECC functions
-- 
1.5.3.2


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

--- End Message ---

Attachment: signature.asc
Description: Digital signature

Reply via email to