From a user perspective, I still think the aux key makes more sense. It is the largest and brightest led, we need an obvious indication that 'something is going on'. If the aux leds are used for any other indications, we should synchronize this, as in, 'aux leds are for indications' whether that be charging, new message, missed calls, etc. That's the idea.
Will ------Original Message------ From: Michael 'Mickey' Lauer Sender: To: [email protected] Cc: Andy Green Cc: Will Sent: Jun 2, 2008 9:41 PM Subject: Re: [PATCH 0/5] Power supply and resume ordering meddling On Monday 02 June 2008 14:27:37 Andy Green wrote: > The following series fixes some bugs around pcf50633 charging; > implements the red LED on the AUX key being lit when pcf50633 > decides to charge; introduces a new method for establishing > resume dependency between drivers; implements this new method > to make jbt6k74 dependent on pcf50633 AND glamo resume before > it resumes, instead of using a sleepy workqueue. > > Let the complaints begin! Here we go: Conceptual complaint: LED on AUX for charging is very suboptimal. Conceptually, the power button has to do with power, so if at all, the power LED needs to be lit on charging. (I know it wasn't your idea, Andy. For my releases, I will revert this patch.) Implementation complaint: a) This hardcoded behaviour should be configurable (CONFIG_HARDCODED_CHARGING_LED) for people who rather want userland to be in control of the LEDs. b) It looks this implementation is completely ignoring the LED class driver which already implements a charging trigger. Why? :M:
