-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Somebody in the thread at some point said: | Somebody in the thread at some point said: | | Andy Green <[EMAIL PROTECTED]> wrote: | | | |> Somebody in the thread at some point said: | |> | |>> I hit this when updating to 2.6.26. Also if CONFIG_MMC is enabled | |>> this patch converts this horrible horrible hack into a horrible | |>> hack by using dev->resume() (untested). | |> Thanks for that, it is much neater. Sent it on to stable. | | | | I find that this patch causes resume not to work, reproducibly, on my | | GTA02. That is to say: I was trying to build a kernel from the tip of | | the 'stable' branch and ran into problems (unresponsive black screen | | when trying to resume via the power button). I did a 'git bisect' and | | isolated it to this commit, and reverting this commit (only) caused the | | problem to go away for me. | | | | Is it possible that "dev->resume()" is not properly initialised somehow? | | As far as I can see, this patch isn't meant to be anything more than a | | tidy-up. I'd love to have a go at tracking this down myself, but my | | weekend reading on Linux Kernel Development is still in the post from | | Amazon... | | Thanks for the effort isolating it, Mike too, I will look at it | thismorning.
Yes the trouble is coming from dev->dev.driver being a struct device_driver which has a (*resume) composed in it, but in fact the Glamo's resume is defined in a separate struct platform_driver elsewhere which has the real (*resume) we want in it. So it looks really good to the eye but is wrong. This code and almost all or all of the resume_dependency stuff is gone in the device tree changes for 2.6.26, so rather than try to figure out how to derive the correct pointer I will revert this part of the patch. - -Andy -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org iEYEARECAAYFAkjkq00ACgkQOjLpvpq7dMrE9gCfTIAAZL6ElXZ7TfUTvsxsQQ8N XGUAn3m7gg1hHNHYQZJxo9AEmImMMP5r =QBnG -----END PGP SIGNATURE-----
