Andy Green wrote: > + unsigned int use_bbt : 1; I think this hunk and the use of use_bbt should go into a separate patch.
> #ifdef CONFIG_MTD_NAND_S3C2410_DEBUG > -#define DEBUG > +#ifndef DEBUG > +#define DEBUG 1 > +#endif > #endif Do we actually need this ? Even if we do, I don't think it has anything to do with how we configure our partitions. > - dev_dbg(info->device, "NF_CONF is 0x%lx\n", cfg); > - What's wrong with it ? Also, doesn't seem to have much to do with the partitions. > - return -1; > + return -EBADMSG; This looks like a regression. The expected return value is -1, see the call to ecc.correct in nand_read_subpage in nand_base.c The rest looks good, but parsing the complete device-independent partitions in the driver may draw some objections. We'll see. - Werner
