Hi

i can run lastest andy-tracking on my GTA01, and that's because from all your 
good work, thank you!

But there are some problems... :(

* Suspend doesn't work
* rmmod snd_soc_neo1973_wm8753 does segfault (see last mail)
* cat /proc/asound/cards shows no sound card

I have searched for the segfault thing and found two other little things:
* BT-DAI: Was implemented for GTA02 but seems to be missing on GTA01
  I'm not shure if it's correct, that it is threre, but i think so.
  I have attached a patch for this.
* in mach-gta01.c is a "lm4587" listed, but i think is has to be "lm4857" (5,8
  swapped). I attached a patch for this.
  In an older version of this code it is "neo1973_lm4857", not "lm4857". What is
  correct?

Tim Niemeyer
From 52da4d313dd3263824023f6f3c16a32a0078710e Mon Sep 17 00:00:00 2001
From: Tim Niemeyer <[email protected]>
Date: Thu, 5 Mar 2009 10:59:40 +0100
Subject: [PATCH] Typo in I2C device registration

Signed-off-by: Tim Niemeyer <[email protected]>
---
 arch/arm/mach-s3c2410/mach-gta01.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-s3c2410/mach-gta01.c b/arch/arm/mach-s3c2410/mach-gta01.c
index aeb66fb..27bf359 100644
--- a/arch/arm/mach-s3c2410/mach-gta01.c
+++ b/arch/arm/mach-s3c2410/mach-gta01.c
@@ -922,7 +922,7 @@ static struct i2c_board_info gta01_i2c_devs[] __initdata = {
 		.platform_data = &gta01_pcf_pdata,
 	},
 	{
-		I2C_BOARD_INFO("lm4587", 0x7c),
+		I2C_BOARD_INFO("lm4857", 0x7c),
 	},
 	{
 		I2C_BOARD_INFO("wm8753", 0x1a),
-- 
1.5.6.5

From b003024f41b34cc9a8442f7dab1b9ce099faf08b Mon Sep 17 00:00:00 2001
From: Tim Niemeyer <[email protected]>
Date: Thu, 5 Mar 2009 07:15:45 +0100
Subject: [PATCH] fix-alsa-bt-dai-registration-missing

---
 sound/soc/s3c24xx/neo1973_wm8753.c |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/sound/soc/s3c24xx/neo1973_wm8753.c b/sound/soc/s3c24xx/neo1973_wm8753.c
index 8b0edc5..2a89b41 100644
--- a/sound/soc/s3c24xx/neo1973_wm8753.c
+++ b/sound/soc/s3c24xx/neo1973_wm8753.c
@@ -719,6 +719,11 @@ static int __init neo1973_init(void)
 		return -ENODEV;
 	}
 
+	/* register bluetooth DAI here */
+	ret = snd_soc_register_dai(&bt_dai);
+	if (ret)
+		return ret;
+
 	neo1973_snd_device = platform_device_alloc("soc-audio", -1);
 	if (!neo1973_snd_device)
 		return -ENOMEM;
@@ -744,6 +749,7 @@ static void __exit neo1973_exit(void)
 {
 	DBG("Entered %s\n", __func__);
 
+	snd_soc_unregister_dai(&bt_dai);
 	i2c_unregister_device(lm4857_client);
 	i2c_del_driver(&lm4857_i2c_driver);
 	platform_device_unregister(neo1973_snd_device);
-- 
1.5.6.5

Attachment: signature.asc
Description: Digital signature

Reply via email to