Hallo Werner, ok, but in the commit i can't see the new coding style! The Comment in the code is copied.
I build a patch for CodingStyle with copy-src also fixed. Maybe it's better to replace the old patch with a new one, but then i have to figure out how i can change an old commit in GIT. ;-) Thanks, Tim * Werner Almesberger <[email protected]> [26-03-09 01:26]: > From: Werner Almesberger <[email protected]> > To: [email protected] > Cc: [email protected], > Tim Niemeyer <[email protected]> > Subject: Re: [PATCH] extend work around boot-time ordering on GTA01 > Date: Thu, 26 Mar 2009 01:26:27 -0300 > > [email protected] wrote: > > Subject: [PATCH] extend work around boot-time ordering on GTA01 > > Applied with coding style changes: Documentation/CodingStyle lines 166 > and 448, put blank line after local variables. > > Commmit 1350d5dfaac7dadf6cab9e812f0acfabcce60e58 > > Thanks, > - Werner > Tim Niemeyer
From b03550ac94a5a48139e68d239ce70c84c3518266 Mon Sep 17 00:00:00 2001 From: Tim Niemeyer <[email protected]> Date: Thu, 26 Mar 2009 05:38:52 +0100 Subject: [PATCH] Some CodingStyle Signed-off-by: Tim Niemeyer <[email protected]> --- arch/arm/mach-s3c2410/mach-gta01.c | 6 ++++-- drivers/power/pcf50606-charger.c | 9 +++++---- 2 files changed, 9 insertions(+), 6 deletions(-) diff --git a/arch/arm/mach-s3c2410/mach-gta01.c b/arch/arm/mach-s3c2410/mach-gta01.c index 2af4df5..204a663 100644 --- a/arch/arm/mach-s3c2410/mach-gta01.c +++ b/arch/arm/mach-s3c2410/mach-gta01.c @@ -676,9 +676,11 @@ static struct vbus_draw gta01_udc_vbus_drawer; static void __gta01_udc_vbus_draw(struct work_struct *work) { - /* this is a fix to work around boot-time ordering problems if the + /* + * this is a fix to work around boot-time ordering problems if the * s3c2410_udc is initialized before the pcf50606 driver has defined - * pcf50606_global */ + * pcf50606_global + */ if (!gta01_pcf) return; diff --git a/drivers/power/pcf50606-charger.c b/drivers/power/pcf50606-charger.c index fb02a79..2ac0a36 100644 --- a/drivers/power/pcf50606-charger.c +++ b/drivers/power/pcf50606-charger.c @@ -36,13 +36,14 @@ struct pcf50606_mbc { void pcf50606_charge_fast(struct pcf50606 *pcf, int on) { struct pcf50606_mbc *mbc = platform_get_drvdata(pcf->mbc_pdev); - /* this is a fix to work around boot-time ordering problems if + + /* + * this is a fix to work around boot-time ordering problems if * the s3c2410_udc is initialized before the pcf50606 mbc is - * ready */ + * ready + */ if (!mbc) - { return; - } if (on) { pcf50606_reg_set_bit_mask(pcf, PCF50606_REG_MBCC1, -- 1.5.6.5
signature.asc
Description: Digital signature
