On Wed, Sep 23, 2009 at 12:52 AM, Vasily Khoruzhick <[email protected]> wrote: > В сообщении от 23 сентября 2009 00:55:52 автор Nelson Castillo написал: >> On Tue, Sep 22, 2009 at 4:47 PM, Sveinung Kvilhaugsvik >> >> <[email protected]> wrote: >> > Great news from Ben Dooks: >> > http://lists.infradead.org/pipermail/linux-arm-kernel/2009-September/0011 >> >31.html >> >> Indeed. >> >> We also need this to boot from the Linus kernel. I'll send it later. >> >> diff --git a/arch/arm/mach-s3c2442/Kconfig b/arch/arm/mach-s3c2442/Kconfig >> index 103e913..8b168f9 100644 >> --- a/arch/arm/mach-s3c2442/Kconfig >> +++ b/arch/arm/mach-s3c2442/Kconfig >> @@ -33,6 +33,7 @@ config MACH_NEO1973_GTA02 >> select POWER_SUPPLY >> select MACH_NEO1973 >> select S3C2410_PWM >> + select S3C_DEV_NAND >> help >> Say Y here if you are using the Openmoko GTA02 / Freerunner GSM >> Phone >> > > You don't need to do this. > S3C_DEV_NAND should be selected by ARCH_S3C2410, but this behavior was broken. > Look at http://patchwork.kernel.org/patch/48995/ > AFAIK this patch is already accepted by Ben Dooks.
Hello Vasily. In the same patch I read this: >The best solution (although it does touch a number of Kconfig files) >is to ensure each machine that requires the s3c_device_nand defines >a select in their machine Kconfig. I guess I'll send the patch and no harm will be done if it gets rejected. IMHO it is useful as documentation also. If sending this patch is a known-to-be-bad thing please let me know.
