Jorn,

Sorry, I've been busy... The default was because I didn't know the default state for many of the models. Most of the time it is based on how they are created. I can fix that easily; so that it gets set to true if not present.

The static was required because the function is static and doesn't have access to the non-static members. I agree it was a nasty compromise. The other way to go would be to add the serializing to the Dictionary object itself... but, I don't know the problems with growing the Dictionary class too large... lastly, we could have the serializing as non-static meaning we would need to create a DictionarySerializer to use.

James

I'm also not familiar with the
On 8/8/2011 10:32 AM, Jörn Kottmann (JIRA) wrote:
     [ 
https://issues.apache.org/jira/browse/OPENNLP-239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13080971#comment-13080971
 ]

Jörn Kottmann commented on OPENNLP-239:
---------------------------------------

One more comment, the case sensitive flag in DictionarySerializer must not be 
static, because this causes a thread safety issue.
We need to find another way to implement this.

Case Sensitivie Flag&  Custom Tag Dictionary
--------------------------------------------

                 Key: OPENNLP-239
                 URL: https://issues.apache.org/jira/browse/OPENNLP-239
             Project: OpenNLP
          Issue Type: New Feature
          Components: Parser
    Affects Versions: tools-1.5.1-incubating
            Reporter: mark meiklejohn
            Assignee: James Kosin
             Fix For: tools-1.5.2-incubating


Unable to set case sensitive flag as per TreebankParser 1.3.1 or use a custom 
tag dictionary
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira



Reply via email to