Re: svn commit: r1159447 - in /incubator/opennlp/trunk/opennlp-tools/src: main/java/opennlp/tools/chunker/ main/java/opennlp/tools/cmdline/chunker/ main/java/opennlp/tools/cmdline/namefind/ main/java/opennlp/tools/cmdline/postag/ main/java/opennlp/to

[Jörn Kottmann]

On 8/23/11 6:07 AM, william.co...@gmail.com wrote:

I added variable length param only for the Chunker. Please check if it looks
OK. If yes I will do it for the other tools.

Looks good to me, you don't need the null check for the variable length
param. If the user passes null, he gets a NullPointerException.

In the case he doesn't pass anything you get an empty array.

What do you think, is the variable length param way better than the other?

Jörn