Sure, we always have a look at new jira issues and patches are always reviewed before they are committed. So there is no need to worry about not getting everything right the first time. Making patches also takes a bit time to get used to.
Jörn On Thu, Feb 9, 2012 at 10:51 AM, Katrin Tomanek <[email protected]>wrote: > Hi Jörn, > > Yes, I try to do this. > > Actually, I am new to JIRA. I am just reading and checking out stuff and > then starting. Maybe it would be a good idea if you could check what I am > doing (just to make sure I am not destroying something). > > Best > Katrin > > > P.S.: I just changed the EOS in the factory and it works! Thanks for > helping me so far! > > > On 02/09/2012 10:48 AM, Joern Kottmann wrote: > >> On Thu, Feb 9, 2012 at 10:30 AM, Katrin Tomanek >> <[email protected]>**wrote: >> >> Hi, >>> >>> but somehow we have to force the model to know which context generator >>> and >>> eos scanner to use. Otherwise, the features extracted during training and >>> during testing are inconsistent. >>> >>> I believe this is absolutely to be avoided -- otherways I cannot trust my >>> model. >>> >>> Maybe, for convenience, this could be done: >>> - if you are just interested in using different EOS chars (but still >>> going >>> with the default context generator for feature extraction), then EOS >>> chars >>> can be defined during training and will be stored in the model >>> - and for better customization, we might also allow users to specify a >>> custom factory which is stored in the model and insures consistency. >>> >>> What do you think? >>> >>> >>> +1 to both. >> >> I suggest that you open a jira for the EOS improvement. It would of course >> be very nice >> if you can contribute this change. We receive contributions always via >> patches which >> are attached to the jira issues. >> >> Jörn >> >> > > -- > Dr. Katrin Tomanek > Averbis GmbH > Tennenbacher Strasse 11 > D-79106 Freiburg > > Fon: +49 (0) 761 - 203 97696 > Fax: +49 (0) 761 - 203 97694 > E-Mail: [email protected] > > Geschäftsführer: Dr. med. Philipp Daumke, Dr. Kornél Markó > Sitz der Gesellschaft: Freiburg i. Br. > AG Freiburg i. Br., HRB 701080 >
