On Tue, Jun 17, 2008 at 10:22 AM, Benjamin Reed <[EMAIL PROTECTED]> wrote:
> Matt Brozowski wrote:
>
>> Hi DJ,
>>
>> I did some research with David and figured out that if you use a Reader
>> then the encoding set in the xml file is ignored. if you use a InputStream
>> then the encoding is set based on the value in the xml file.
>>
>> So it is most appropriate to use InputStream for unmarshalling all xml
>> files. Then we can specify in the file its encoding.
>>
>> I think your ideas for CastorUtils and the Castor DAO class make a lot of
>> sense.
>>
>
> Is this something important enough to try to get done today and in 1.5.92?
> It seems like it's a good thing to do, but also has a potential for
> breaking things without a little time for settling down.
I would not say its a blocker to change all of the files for 1.5.92. The
majority of the files only have 'key words' such SNMP and not user visible
words like the importer file had (it had nodeLabels). Also there is a work
around of creating an xml 'entity' with the unicode for the charachter and
using that as a substitution. We can do it in 1.5.93 without really
bothering anyone. I don't think it is likely to break anything however.
All of the old files that are read as it is will still be parsed properly in
both cases (though it may be good to explicitly indicate the encoding for
the files) and Reader and InputStream interfaces are nearly identical.
They only difference being the Reader implies an encoding whereas the
InputStream does not.
Matt
-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
_______________________________________________
Please read the OpenNMS Mailing List FAQ:
http://www.opennms.org/index.php/Mailing_List_FAQ
opennms-devel mailing list
To *unsubscribe* or change your subscription options, see the bottom of this
page:
https://lists.sourceforge.net/lists/listinfo/opennms-devel
