Hi everyone, Over the holidays, we had some Bamboo breakages in 1.12 due to several code changes that were made immediately before the holidays that did not pass unit tests and/or smoke tests. If you are committing code to the stable branch of OpenNMS, please observe the following practices:
- Be conservative about what you are committing. If you want to fix a bug, please just check the bugfix code into 1.12. If you do other cleanup in the code at the same time that produces a large diff, commit those cleanup changes to master. Innocuous cleanup can often cause unintended breakages. - At the very least, run the unit tests for the module that you are editing. This is the bare minimum that you should be doing before committing. Ideally, you should run the entire unit test suite, install the code, and then run smoke tests against the installed copy of OpenNMS. This is time-consuming but it is the only way to ensure that you won't cause the Bamboo builds to fail. - Commit your code to a branch first, ask us to add it to Bamboo, and let Bamboo test your branch before merging the changes into 1.12. If you want to make regular bugfixes in 1.12, I highly recommend this option because it automates the unit and smoke testing for you. I personally do this on master with my soleger-master branch so that I can ensure that my ongoing development won't break the master branch before I do any merges. Thanks, Seth Leger The OpenNMS Group ------------------------------------------------------------------------------ Rapidly troubleshoot problems before they affect your business. Most IT organizations don't have a clear picture of how application performance affects their revenue. With AppDynamics, you get 100% visibility into your Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro! http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk _______________________________________________ Please read the OpenNMS Mailing List FAQ: http://www.opennms.org/index.php/Mailing_List_FAQ opennms-devel mailing list To *unsubscribe* or change your subscription options, see the bottom of this page: https://lists.sourceforge.net/lists/listinfo/opennms-devel
