I think solving multiple issues in one PR is not a problem. I just remembered 
the case, when Markus had to backport issues after while and it was hard to 
figuring out which commits where made to solve this issue. I think what Jesse 
and Markus mentioned make totally sense and something worth to keep in mind 
when we merge PRs.

> On 1 Feb 2017, at 15:31, Seth Leger <s...@opennms.com> wrote:
> 
> Another point, I think it's my PRs that sometimes address multiple
> issues. This is not normally my plan but sometimes on a branch where I
> am working, I realize that I could easily add a fix for an additional
> issue in code that I am already editing. That's why multiple issues
> appear in the same PR.
> 
> Cheers,
> Seth
> 
> 
> On 2/1/17 6:28 AM, Markus von Rüden wrote:
>> Yep, I agree as well.
>> 
>> In case it is unclear, each commit should look something like this:
>> 
>> NMS-1000: Prevent NullPointerException
>> HZN-1000: Prevent NullPointerException
>> 
>> This makes it easier to find commits related to a commit.
>> 
>>> On 31 Jan 2017, at 15:55, Jesse White <je...@opennms.org
>>> <mailto:je...@opennms.org>> wrote:
>>> 
>>> This sounds like good practice to me.
>>> 
>>> I don't see any problems with addressing multiple issues in a single
>>> pull request as long as the commits are related and properly identified.
>>> 
>>> -Jesse
>>> 
>>> 
>>> On 01/27/2017 04:18 AM, Ronny Trommer wrote:
>>>> Hi Everyone,
>>>> 
>>>> I’ve seen we have some Pull Requests (PR) which address multiple
>>>> issues in JIRA. As I can remember when we have to back port things or
>>>> have to investigate later changes in source code I can envision a few
>>>> problems with this PRs.
>>>> 
>>>> - It would become hard to backport a single issue to some release if
>>>> needed or when changes needs to be investigated after a while when
>>>> no-one remembers what has been changed. To address this type of
>>>> issues it would help to add NMS-<something> / HZN-<something> in
>>>> front of the commit especially in this type of PRs. it would make it
>>>> easier cause a git log search would help to figuring out which code
>>>> changes belong to which issue, see
>>>> here: 
>>>> https://github.com/OpenNMS/opennms/pull/1247/commits/ebe616e559872c0ccdf9e1ad10f49027aa5aed61
>>>> 
>>>> In case a PR is just solving a single issue GitHub gathers all
>>>> changes required to solve this issue. It would just always require to
>>>> go into GitHub closed PRs and search for the issue number. If we want
>>>> to just use git log search the “NMS-/HZN-“ issue number in front of
>>>> the commit would make that one easier as well.
>>>> 
>>>> Just my thoughts
>>>> 
>>>> Feedback welcome
>>>> 
>>>> Ronny
>>>> 
>>>> 
>>>> 
>>>> 
>>>> 
>>>> ------------------------------------------------------------------------------
>>>> Check out the vibrant tech community on one of the world's most
>>>> engaging tech sites, SlashDot.org <http://SlashDot.org>! 
>>>> http://sdm.link/slashdot
>>>> 
>>>> 
>>>> _______________________________________________
>>>> Please read the OpenNMS Mailing List FAQ:
>>>> http://www.opennms.org/index.php/Mailing_List_FAQ
>>>> 
>>>> opennms-devel mailing list
>>>> 
>>>> To *unsubscribe* or change your subscription options, see the bottom of 
>>>> this page:
>>>> https://lists.sourceforge.net/lists/listinfo/opennms-devel
>>> 
>>> ------------------------------------------------------------------------------
>>> Check out the vibrant tech community on one of the world's most
>>> engaging tech sites, SlashDot.org <http://SlashDot.org>!
>>> http://sdm.link/slashdot_______________________________________________
>>> Please read the OpenNMS Mailing List FAQ:
>>> http://www.opennms.org/index.php/Mailing_List_FAQ
>>> 
>>> opennms-devel mailing list
>>> 
>>> To *unsubscribe* or change your subscription options, see the bottom
>>> of this page:
>>> https://lists.sourceforge.net/lists/listinfo/opennms-devel
>> 
>> 
>> 
>> ------------------------------------------------------------------------------
>> Check out the vibrant tech community on one of the world's most
>> engaging tech sites, SlashDot.org! http://sdm.link/slashdot
>> 
>> 
>> 
>> _______________________________________________
>> Please read the OpenNMS Mailing List FAQ:
>> http://www.opennms.org/index.php/Mailing_List_FAQ
>> 
>> opennms-devel mailing list
>> 
>> To *unsubscribe* or change your subscription options, see the bottom of this 
>> page:
>> https://lists.sourceforge.net/lists/listinfo/opennms-devel
>> 
> 
> 
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, SlashDot.org! http://sdm.link/slashdot
> _______________________________________________
> Please read the OpenNMS Mailing List FAQ:
> http://www.opennms.org/index.php/Mailing_List_FAQ
> 
> opennms-devel mailing list
> 
> To *unsubscribe* or change your subscription options, see the bottom of this 
> page:
> https://lists.sourceforge.net/lists/listinfo/opennms-devel


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Please read the OpenNMS Mailing List FAQ:
http://www.opennms.org/index.php/Mailing_List_FAQ

opennms-devel mailing list

To *unsubscribe* or change your subscription options, see the bottom of this 
page:
https://lists.sourceforge.net/lists/listinfo/opennms-devel

Reply via email to