Hi Hendrik,

> > Some comments on the patch.
> [...]
> > And I think the usage of tabs vs. whitspaces is mixed up. Pick one.
> 
> That was copy&paste. I usually use whitespace for alignment (tabs may look 
> different in most editors).

I prefer to use tabs, but did you actually tried to use your patch? I
saw stuff like this:

In file included from obex_main.h:58,
                 from obex_main.c:54:
../include/openobex/obex_const.h:148:1: warning: "OBEX_HDR_TYPE" redefined
../include/openobex/obex_const.h:121:1: warning: this is the location of the 
previous definition

Compiler warnings normally mean something. And in this case you tricked
yourself.

Anyway, I fixed it and the patch is in the CVS now.

Regards

Marcel



-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys -- and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Openobex-users mailing list
[email protected]
http://lists.sourceforge.net/lists/listinfo/openobex-users

Reply via email to