Hi Manuel,

your hci selection option is a nice addition to ObexFTP, thanks. Not
every OpenOBEX feature is implemented in ObexFTP right now, but it would
be nice to get there someday.

- Is the hci-id really something we need in the client struct? Isn't it
something like device and channel?
  I'm thinking of discovery here, would the user perhaps want to
discover from all devices, then select hci-id along with device and channel?

- I'm open to changes in coding style (the bt_discovery.c is mostly
copied example code in GNU style, other code is mostly K&R style).
Please submit seperate patches though.

- Please don't remove '(void)' from functions it's nice to have those
with lint.

- If possible please diff against the current svn/cvs (see the wiki/trac).

- And then perhaps submit patches to the bug tracker there.

Again thanks for your ideas and work on this.


regards,
Christian

Manuel Naranjo schrieb:
> lets the user select the hci device
> apps/bt_discovery.c it was very bad formated and I had to ident it
> before starting to code
> actually I'm not making lots of modifications, but having reidented
> the file made diff crazy.
> it applies to the obexftp-0.20 source package


-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
Openobex-users mailing list
[email protected]
http://lists.sourceforge.net/lists/listinfo/openobex-users

Reply via email to