Hi Hendrik,

>>> To make it easier for you: here's the patch to update the project  
>>> version for
>>> the CMake build files.
>>> This does not update the autotools files like configure.ac and doc/ 
>>> Doxyfile.
>> so I have all the changes for the release preparation ready to commit.
>> However can someone please look at the soname and see if that one is
>> correct. Otherwise I am going to release openobex-1.4 today.
> 
> 1.
> No version information patch is in the GIT tree, thus no way to check if
> they are right.

never committed it. So no wonder that it didn't get pushed. Fixed now.

> 2.
> The README file is actually not the correct place for installation
> instructions, that's what the INSTALL(.txt) file is for. A README file
> is installed with the already-built library and should give usage
> instruction, e.g. point to the complete documentation.
> Should the other committers add their own copyright line?

We have the general INSTALL file, but I also like to keep a quick 
install intructions in the README.

Make sure your name is in the AUTHORS file and before the next release I 
have to go through the code base and add proper up-to-date copyright 
headers.

> 3.
> If you disable the GLIB binding in the autotools build, please also do
> this in the CMakeLists.txt file by commenting the line 167.
> I can provide a patch for that.

Done that now. Thanks for the hint.

> Those points should be fixed before release, please.
> 
> The following are not release-critical but still...
> 4.
> openobex(-glib).pc.in should move to lib/ and glib/ subdirs, actually.

No. I like them in the top-level directory.

> 5.
> Remove the empty NEWS file.

Actually autoconf/automake doesn't really like that :)

> 6.
> Do you want to keep the openobex.m4 file?

I keep it around for now, but not install it. We do the same for BlueZ, 
but sometime in the future it will go away.

Regards

Marcel


-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Openobex-users mailing list
[email protected]
http://lists.sourceforge.net/lists/listinfo/openobex-users

Reply via email to