Hi Hendrik, > >> > > I updated my "updates" branch on gitorious to do what I previously > >> > > indicated. It looks much more sane to me, now. I did not test this on > >> > > Win32, so you may delay pulling that to your tree. > >> > > >> > Pulled and pushed back out. Thanks > >> > > >> > I fixed all other warnings and made most pending details static. And now > >> > it was possible to enable -Werror :) > >> > > >> > Please test and report back with results. I am holding off the release > >> > until we resolved all the details. > >> > >> With the additional patches in my "updates" branch on gitorious, it > >> compiles > >> with MSVC 7-9 without any warning (all warnings are errors there, too). > > > > pulled your updates, but now "make distcheck" fails. Main reason is that > > it doesn't find the obex_incl.h file. > > The following files in lib/ are not noted in lib/Makefile.am: > obex_incl.h > visibility.h > debug.h
and defines.h of course, but then it works again. > Adding them should work for you. I need to add them, in CMakeLists.txt also. Send a patch that makes this work for you. Fix for that has been pushed now. > >> It should be checked that all files are in the distribution, don't > >> know for the > >> new header files. How about the INSTALL.txt and INSTALL_Win32.txt file? > > > > They have to be in EXTRA_DIST, otherwise they don't end up in the > > package. > > I'll check that. > > Essentially, "make dist" should include all files that are in the > repository. All missing ones need to be added. Isn't there a way to > make "make dist" tell you all the files that it's not including? Like > "hey, you should check that you really don't want to the following > files in your package:". > After all, "make distcheck" doesn't check for missing documentation or > anything that's not built with autotools :-( > > I cannot look into this before tomorrow. Please do so. Regards Marcel ------------------------------------------------------------------------------ OpenSolaris 2009.06 is a cutting edge operating system for enterprises looking to deploy the next generation of Solaris that includes the latest innovations from Sun and the OpenSource community. Download a copy and enjoy capabilities such as Networking, Storage and Virtualization. Go to: http://p.sf.net/sfu/opensolaris-get _______________________________________________ Openobex-users mailing list [email protected] http://lists.sourceforge.net/lists/listinfo/openobex-users
