Howdy,

      A quick look at the code, there is a brand new tiva.c driver, which
looks like a cleaned up version of the stellaris.c with support for the
tiva family (the tiva-snowflake platform has been added) and room to have
more Tiva parts supported.

Personally I like it this way, for the Tiva family to have tiva.c driver,
and the older stellaris family to have its own stellaris.c.

The only thing is that the new patch also work with the tiva launchpad
TM4c123xgl  ( which is a rename of the stellaris F120), but i dont see it
"Literally" in the code of tiva.c. Most probably they both work the same
way I guess. It will be nice to have the TM4C123XGL added to the new
tiva.c, this way and finally the 2 families are separated in a cleaner way.
So you can have tiva_icdi.cfg (using tivac driver) and stellaris_icdi.cfg
(using legacy stellaris driver). As stated in the patch one family uses 1K
flash-page and the newer one uses 16K flash-page (most probably thats why
it is faster download???).

This is just a quick observation.

Cheers./







On Sun, Jan 12, 2014 at 6:36 PM, Peter Stuge <pe...@stuge.se> wrote:

> ger...@openocd.zylin.com wrote:
> > This is an automated email from Gerrit.
> >
> > Heinz Schweiger (open...@htl-steyr.ac.at) just uploaded a new patch set
> to Gerrit, which you can find at http://openocd.zylin.com/1869
>
> How much of this patch is pure copypaste and how much is actually new code?
>
> Could the stellaris driver simply be refactored instead, or how about
> still having two drivers but factoring out everything that is common?
>
>
> //Peter
>
>
> ------------------------------------------------------------------------------
> CenturyLink Cloud: The Leader in Enterprise Cloud Services.
> Learn Why More Businesses Are Choosing CenturyLink Cloud For
> Critical Workloads, Development Environments & Everything In Between.
> Get a Quote or Start a Free Trial Today.
>
> http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk
> _______________________________________________
> OpenOCD-devel mailing list
> OpenOCD-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/openocd-devel
>



-- 
Nader Shehayed
------------------------------------------------------------------------------
CenturyLink Cloud: The Leader in Enterprise Cloud Services.
Learn Why More Businesses Are Choosing CenturyLink Cloud For
Critical Workloads, Development Environments & Everything In Between.
Get a Quote or Start a Free Trial Today. 
http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk
_______________________________________________
OpenOCD-devel mailing list
OpenOCD-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openocd-devel

Reply via email to