On Wed, Oct 29, 2008 at 3:14 AM, hontor <[EMAIL PROTECTED]> wrote:
>
>  Hi,
>    Today I have a test for SVN 1112, there is a
> problem.arm7_9_restore_context(target) should be invoked after
> arm_simulator(target, next_pc).arm7_9_step has one call.seems not good in
> enable_single_step().
>     So, I have convert to my old change,then I modify
> feroceon_enable_single_step(), add a parameter that is u32 next_pc,delete
> arm_simulator call,because it is done in arm7_9_step().
>     This is the best way to deal it like xscale.c.
>     I have tested the patch,it works well.
>     If I was wrong ,please tell me.
>     Thanks.

To me this patch looks good.

I am giving this patch a period of cooloff to see that we now have the final
version of these changes.

By the way: please number your patches :-) it is hard to keep track of which one
is the newest one.

For example:

mypatch.txt
mypatch2.txt
mypatch3.txt


-- 
Øyvind Harboe
http://www.zylin.com/zy1000.html
ARM7 ARM9 XScale Cortex
JTAG debugger and flash programmer
_______________________________________________
Openocd-development mailing list
[email protected]
https://lists.berlios.de/mailman/listinfo/openocd-development

Reply via email to