target_create() was being invoked twice.

This had lots of strange effects, none directly lethal:

- registers for e.g. xscale was listed twice
- "reg pc 0x1234" + "step" was broken.

I suspect Cortex targets would have experienced similar problems.

target_create() could need a bit of extra error checking. Although
unlikely, type->target_create() *can* fail.

### Eclipse Workspace Patch 1.0
#P openocd
Index: src/target/target.c
===================================================================
--- src/target/target.c (revision 1123)
+++ src/target/target.c (working copy)
@@ -3828,7 +3828,6 @@
                                                   target, /* private data */
                                                   NULL ); /* no del proc */

-       (*(target->type->target_create))( target, goi->interp );
        return e;
 }




-- 
Øyvind Harboe
http://www.zylin.com/zy1000.html
ARM7 ARM9 XScale Cortex
JTAG debugger and flash programmer
_______________________________________________
Openocd-development mailing list
[email protected]
https://lists.berlios.de/mailman/listinfo/openocd-development

Reply via email to