I have attached a version without goto. - jtag.c, interface_jtag_add_ir_scan() [2/2] (version without goto): - change 'found' to bool - add comments on loops
Michael On Thu, May 21, 2009 at 7:01 AM, Rick Altherr <kc8...@kc8apf.net> wrote: > > On May 20, 2009, at 8:30 PM, Michael Bruck wrote: > >> - jtag.c, interface_jtag_add_ir_scan() [2/2]: >> - retire variable 'found' and use goto instead >> - add comments on loops >> >> Michael >> < >> commit >> -11-506cef0.patch>_______________________________________________ >> Openocd-development mailing list >> Openocd-development@lists.berlios.de >> https://lists.berlios.de/mailman/listinfo/openocd-development > > > I'm not really keen on the use of goto in this case. The use of found > breaks the code into two clear phases: locate the fields for the tap, and > process the fields for that tap. The goto confuses the flow when reading > the code. > > -- > Rick Altherr > kc8...@kc8apf.net > > "He said he hadn't had a byte in three days. I had a short, so I split it > with him." > -- Unsigned > > > >
commit-11b-d5c73bb.patch
Description: Binary data
_______________________________________________ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
