On Sun, 2009-11-15 at 16:11 -0700, David Brownell wrote: > On Sunday 15 November 2009, Zach Welch wrote: > > > > > > I'd be happier if it were called DIV_ROUND_UP() like a > > > certain OS kernel I could mention ... not as cryptic. > > > > I agree that the current name stands to be improved. > > > > > (Likewise, there's a DIM which is used for ARRAY_SIZE. > > > And lots of re-inventions of that, since DIM is a > > > really un-obvious name for "what size is this array".) > > > > Again, I agree. I would be happy to handle these, but feel free to > > provide patches yourself them yourselves. Incidentally, I would like to > > see this later macro go into types.h, which is also where I suggest > > putting the container_of macro that is being used in the target layer. > > Fine with me. If I can persuade you to do those > three cleanups, I'd be happier. ;)
I've posted my series to do this, now it's your turn. :) Remove the 'extern' in arm9tdmi.c (referencing arm7tdmi) by moving the arm_endianness routine somewhere better. I am not certain where that would be, without also creating patches to add arm.[ch]. ;) Cheers, Zach _______________________________________________ Openocd-development mailing list [email protected] https://lists.berlios.de/mailman/listinfo/openocd-development
