On Sun, Nov 22, 2009 at 2:05 AM, Zach Welch <z...@superlucidity.net> wrote: > On Sun, 2009-11-22 at 01:56 +0100, Andreas Fritiofson wrote: >> On Sun, Nov 22, 2009 at 1:13 AM, Zach Welch <z...@superlucidity.net> wrote: >> > Checkout your branch and run 'git rebase master'. That will update your >> > branch against the current master. Then, do the same thing with '-i'. >> > Select the patches to change and mark them with 'e', change the files, >> > add them and --amend the comment, then --continue the rebase. Rinse and >> > repeat for all marked files. >> >> Great, that was easy, thanks! Here's an updated patch, this time using >> C99 variable length arrays. I'm using the unbounded string functions >> here, guessing we can trust getenv() to return a piece of memory that >> won't change on the fly. > > Tuck the 'suffix' variable into the scope of the 'if' block. > > Documentation? :) That can be part of the same patch. > >> Btw, is it suitable to attach an updated patch as an attachment like >> this? I thought git-send-email was fancy, but I hardly think it can >> figure out to send the new patch as a reply in the old thread? > > When I run it, it asks me for the message-id to which it should reply. > > Also, I prefer to see patches in-line (not as attachments), as it's much > easier to review them then save a series to import with 'git am'. > > --Z >
Aha, will try that. I'll include some doc updates which i just finished. /Andreas _______________________________________________ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
