On Thu, 2009-12-03 at 10:39 +0100, Øyvind Harboe wrote: > I added a missing #include <sys/stat.h>, but it is not quite ready to commit > yet I think. > > Does it build under Windows? Perhaps it does, I didn't try. > > I don't think we should try to make this work under anything but POSIX > API for now, but the build should not fail. Autotools magic? > > Some docs to openocd.texi would be great.
Okay, one more nit to pick from me too: use a static function to encapsulate the hunk of new code that's being added 4-tabs to the wind. Please, I beg you.... :) I guess I got excited to consider it, then thought I might actually want to look at the patch after that initial enthusiasm started to pass. --Z _______________________________________________ Openocd-development mailing list [email protected] https://lists.berlios.de/mailman/listinfo/openocd-development
