On Saturday 12 December 2009, Marek Vasut wrote:
>
> > I was wondering why to merge something that doesn't have any
> > users ... :)
>
> I have pxa3xx nand driver ready that will need this, preparing ground to
> deploy
> it.
Mmkay...
> > And was also curious what's wrong with the standard erase_page.
> > Is this something that would be needed to support OneNAND, for
> > example?
>
> I need the whole page address when writing the command, not supplied in
> 8bit/16bit values.
That information should be in the patch comment.
Also, can you restructure it so that you don't just add a bit
"if (there's a custom erase_page) { ... }"? That's the sort
of thing which is easier to just require. Either provide the
current logic in a separate routine that gets patched into the
ops vector of any driver that doesn't have it, or (probably
better) just export that routine and update all the NAND drivers
to provide it. (Better because we actually want to see all the
driver structs be "static const" someday: read-only.)
That'll be easier to review too.
- Dave
_______________________________________________
Openocd-development mailing list
Openocd-development@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/openocd-development
