In attachment there is the first patch of the set, compressed.
It just touches the following files:
./BUGS
./NEWS-0.2.0
./NEWTAPS
./PATCHES
./README.Win32
./TODO
./bootstrap
./configure.in
./doc/manual/primer/commands.txt
./doc/manual/release.txt
./doc/manual/server.txt
./doc/openocd.texi
./ecosflash/notes.txt
./src/server/httpd/menu.xml
./src/server/httpd/menu.xsl
./src/server/httpd/menuweb.css
./src/server/httpd/readme.txt
./testing/examples/PIC32/readme.txt
./testing/index.html
./testing/profile_stm32.txt
./testing/smoketests.html
./testing/testcases.html

The only 2 critical files are ./bootstrap and ./configure.in, but in
both cases the impact is minimal:
- one comment
- one empty line
All the other files are just text or web pages.
I do not see any risk by merging this patch.

I have noticed that some files, like
./testing/build.test1/README.TXT
./testing/build.test2/README.txt
are based on TAB width = 8.

Should every file in the project be converted to TAB width = 4 ?

Best Regards,
Antonio Borneo

On Wed, Dec 30, 2009 at 1:37 AM, Antonio Borneo
<borneo.anto...@gmail.com> wrote:
> I agree, that's why I added comment
> "If, for any reason, you prefer to not apply this patch on current
> rc1, I have no problem to provide an update patch later on."
>
> I already skipped all binary files, and expect patch is safe.
> Anyway, I will provide the patch spitted, and let you decide.
>
> Best Regards
> Antonio
>
> On Wed, Dec 30, 2009 at 1:07 AM, Øyvind Harboe <oyvind.har...@zylin.com> 
> wrote:
>> Spooky.
>>
>> How do we *know* that this doesn't subtly break something?
>>
>> Before 0.4 I would want to break apart this patch and take the
>> least risky ones, e.g. .c/.h files should be safe enough.
>>
>> --
>> Øyvind Harboe
>> US toll free 1-866-980-3434 / International +47 51 63 25 00
>> http://www.zylin.com/zy1000.html
>> ARM7 ARM9 ARM11 XScale Cortex
>> JTAG debugger and flash programmer
>>
>

Attachment: 0001-Code-cleanup.patch.gz
Description: GNU Zip compressed data

_______________________________________________
Openocd-development mailing list
Openocd-development@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/openocd-development

Reply via email to