On Wednesday 20 January 2010, Øyvind Harboe wrote:
> arm7_9 fast_memory_access and working area nags added.
> 
> Signed-off-by: Øyvind Harboe <oyvind.har...@zylin.com>

OK, but it'd be *much* cleaner if it did

        if (!get_target_reset_nag())
                return ERROR_OK;

        if (problem)
                nag(problem)
        ... rinse, repeat ...

> ---
>  src/target/arm7_9_common.c |   10 ++++++++++
>  1 files changed, 10 insertions(+), 0 deletions(-)
> 
> diff --git a/src/target/arm7_9_common.c b/src/target/arm7_9_common.c
> index ca1d84f..509e91e 100644
> --- a/src/target/arm7_9_common.c
> +++ b/src/target/arm7_9_common.c
> @@ -2760,6 +2760,16 @@ int arm7_9_check_reset(struct target *target)
>               LOG_WARNING("NOTE! DCC downloads have not been enabled, 
> defaulting to slow memory writes. Type 'help dcc'.");
>       }
>  
> +     if (get_target_reset_nag() && (target->working_area_size == 0))
> +     {
> +             LOG_WARNING("NOTE! Severe performance degradation without 
> working memory enabled.");
> +     }
> +
> +     if (get_target_reset_nag() && !arm7_9->fast_memory_access)
> +     {
> +             LOG_WARNING("NOTE! Severe performance degradation without fast 
> memory access enabled. Type 'help fast'.");
> +     }
> +
>       return ERROR_OK;
>  }
>  
> -- 
> 1.6.3.3
> 
> _______________________________________________
> Openocd-development mailing list
> Openocd-development@lists.berlios.de
> https://lists.berlios.de/mailman/listinfo/openocd-development
> 


_______________________________________________
Openocd-development mailing list
Openocd-development@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/openocd-development

Reply via email to