On Wednesday 09 December 2009, Nicolas Pitre wrote:
> > > This is wrong for Feroceon and Dragonite which have only one of them.
> > > In that case arm7_9->wp_available_max is initialized to 1 in the
> > > target_create method, but the above message is still wrong and
> > > misleading.
The appended patch behaved on a "real" arm926 ... does it behave
on those cores? (Modulo "1 units" grammatical annoyance, which
I can fix before merge.)
- Dave
========= CUT HERE
Subject: EmbeddedICE - fix Feroceon/Dragonite message
From: David Brownell <dbrown...@users.sourceforge.net>
The breakpoint/watchpoint message is wrong for Feroceon and
Dragonite which have only one of them.
---
src/target/embeddedice.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
--- a/src/target/embeddedice.c
+++ b/src/target/embeddedice.c
@@ -192,6 +192,11 @@ embeddedice_build_reg_cache(struct targe
reg_cache->reg_list = reg_list;
reg_cache->num_regs = num_regs;
+ /* FIXME the second watchpoint unit on Feroceon and Dragonite
+ * seems not to work ... we should have a way to not set up
+ * its four registers here!
+ */
+
/* set up registers */
for (i = 0; i < num_regs; i++)
{
@@ -290,8 +295,8 @@ embeddedice_build_reg_cache(struct targe
buf_get_u32(reg_list[EICE_COMMS_CTRL].value, 0,
32));
}
- LOG_INFO("%s: hardware has 2 breakpoints or watchpoints",
- target_name(target));
+ LOG_INFO("%s: hardware has %d breakpoint/watchpoint units",
+ target_name(target), arm7_9->wp_available_max);
return reg_cache;
}
_______________________________________________
Openocd-development mailing list
Openocd-development@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/openocd-development
