On Fri, Feb 25, 2011 at 4:49 PM, Peter Stuge <pe...@stuge.se> wrote:
> Øyvind Harboe wrote:
>> @@ -349,6 +358,10 @@ COMMAND_HANDLER(handle_svf_command)
>> {
>> svf_quiet = 1;
>> }
>> + else if ((strcmp(CMD_ARGV[i], "nil") == 0) ||
>> (strcmp(CMD_ARGV[i], "-nil") == 0))
>> + {
>> + svf_nil = 1;
>> + }
>
> Maybe we only want new options that use a leading dash?
I don't have a strong opinion on this. There are a fair # of flags
in openocd that don't use dash first.
>> @@ -1705,7 +1736,7 @@ static const struct command_registration
>> svf_command_handlers[] = {
>> .handler = handle_svf_command,
>> .mode = COMMAND_EXEC,
>> .help = "Runs a SVF file.",
>> - .usage = "svf [-tap device.tap] <file> [quiet] [progress]",
>> + .usage = "svf [-tap device.tap] <file> [quiet] [nil]
>> [progress]",
>
> Maybe we messed up adding [-tap] before the filename here. It would
> make the option parser simpler to always have the filename come
> first, like I guess it used to before -tap. But maybe put nil before
> quiet? Or what's the reasoning here?
I just added more of what was already there... Perhaps what's
there should be cleaned up before I push the 'nil' option?
Do you want to have a stab at cleaning it up?
--
Øyvind Harboe
Can Zylin Consulting help on your project?
US toll free 1-866-980-3434 / International +47 51 87 40 27
http://www.zylin.com/zy1000.html
ARM7 ARM9 ARM11 XScale Cortex
JTAG debugger and flash programmer
_______________________________________________
Openocd-development mailing list
Openocd-development@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/openocd-development
