2011/8/26 Michel Catudal <michelcatu...@gmail.com>: > Le 25/08/2011 15:18, Jie Zhang a écrit : >> >> Hi, >> >> There are a lot of coding style mismatch in the current OpenOCD code. >> I'd like suggest setting a rule that asks fixing all coding style >> issues before a patch is merged. >> >> And there are still something missing on >> http://openocd.berlios.de/doc/doxygen/html/stylec.html , like >> >> * how to deal with long list of arguments, which cannot fix in one line? >> * how to place { }? I saw >> >> if (...) { >> } else { >> } >> >> if (...) >> { >> } >> else >> { >> } >> >> * should there be a white space after ( and before )? I saw code both. >> >> >> > If you change to much the diff files can get big.
I don't propose to fix all coding style issue right now. I propose to do coding style check when reviewing patch from now. At some appropriate point in future, we can fix coding style issues at once. > I do agree with you that your suggestion is more appropriate but you will > find people who prefer the other approach. > Personnally I just use the beautify in slickedit to fix that. > I'm not used to the current coding style of OpenOCD. I'm more used to GNU coding style. But I can use the established coding style in OpenOCD without a problem. A consistent coding style is important for the readability and maintenance of software. Regards, Jie _______________________________________________ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
