Hi, I'll try on my chip at home
Best Regards, J. On 10:19 Wed 21 Sep , Peter Tympanick wrote: > Does anyone know if users of OpenOCD can access the ETM Regisiters? > > > Peter Tympanick > Product Manager > Ultimate Solutions, Inc. > ============================================================== > Your Single Source for Professional Development Tools & Embedded Solutions > Ph: 978-455-3383 x202 > Fx: 978-926-3091 > Email: pty...@ultsol.com > Visit: www.ultsol.com > > If your email is related to a technical support issue, please send it to > supp...@ultsol.com to insure a timely response. > > > -----Original Message----- > From: openocd-development-boun...@lists.berlios.de > [mailto:openocd-development-boun...@lists.berlios.de] On Behalf Of Øyvind > Harboe > Sent: Wednesday, September 21, 2011 7:25 AM > To: Clément Burin des Roziers > Cc: openocd-development@lists.berlios.de > Subject: Re: [Openocd-development] STM32L microcontroller support > > It is looking much better. Some more comments: > > 1. I'd remove comments such as the below though. > > > + // Create the bank structure > + stm32lx_info = malloc(sizeof(struct stm32lx_flash_bank)); > + > + // Check allocation > + if (stm32lx_info == NULL) > > 2. Missing error check: > > target_read_u32 > > 3. missing error check: > > stm32lx_wait_until_bsy_clear > > > 4. Resource leakage: > > + // Lock back program memory > + retval = stm32lx_lock_program_memory(bank); > + if (retval != ERROR_OK) > + return retval; > + > + // Free the working areas > + target_free_working_area(target, source); > + target_free_working_area(target, stm32lx_info->write_algorithm); > + > + // Destroy the registers > + destroy_reg_param(®_params[0]); > + destroy_reg_param(®_params[1]); > + destroy_reg_param(®_params[2]); > + destroy_reg_param(®_params[3]); > + > + return retval; > +} > > 5. Bug: > > > + // Wait for busy clear > + retval = stm32lx_wait_until_bsy_clear(bank); > + return retval; > > > > > -- > Øyvind Harboe - Can Zylin Consulting help on your project? > US toll free 1-866-980-3434 > http://www.zylin.com/ > _______________________________________________ > Openocd-development mailing list > Openocd-development@lists.berlios.de > https://lists.berlios.de/mailman/listinfo/openocd-development > _______________________________________________ > Openocd-development mailing list > Openocd-development@lists.berlios.de > https://lists.berlios.de/mailman/listinfo/openocd-development _______________________________________________ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development