On Mon, Sep 19, 2011 at 4:30 PM, Matt Reimer <mrei...@sdgsystems.com> wrote:
> The code in xscale_receive() that tries to skip invalid reads (i.e. > reads that don't have the DBG_SR[0] 'valid' bit set) seems to be > wrong, as it only looks at the first word's valid flag rather than > each word's own valid flag. Am I reading the code correctly? If so, > the attached patch should fix it. > > If this looks correct, I'll generate a proper patch and commit message. > > After a quick glance, your analysis looks right. That also means the result shifting thingy hasn't gotten much exercise. Might be worth an extra look to see if it's correct. For one thing, wouldn't it be more natural (and efficient) to simply loop over the results, emitting the correct ones directly to the buffer while decrementing the word count, than to look for failures and shift the results for each one found? /Andreas
_______________________________________________ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
