This is an automated email from Gerrit.
Uwe Hermann (u...@hermann-uwe.de) just uploaded a new patch set to Gerrit,
which you can find at http://openocd.zylin.com/136
-- gerrit
commit 6ada46d8639bb44800e526111291172506122c0d
Author: Uwe Hermann <u...@hermann-uwe.de>
Date: Sat Oct 29 22:58:12 2011 +0200
config files: Drop incorrect comments.
There are many "force an error till we get a good number" comments in
target/board files. This refers to the use-case where a config script
sets _CPUTAPID to 0xffffffff (which presumely gets overridden later):
if { [info exists CPUTAPID ] } {
set _CPUTAPID $CPUTAPID
} else {
# Force an error until we get a good number.
set _CPUTAPID 0xffffffff
}
However, the same comment was also copy-pasted in many files which do
_not_ set _CPUTAPID to 0xffffffff, where the comment doesn't make any
sense at all. Drop those comments. Also, add one missing comment, and
fix small whitespace and grammar issues.
Change-Id: Ic4ba3b5ccba87ed40cea0d6a7d66609fbdfa3c71
Signed-off-by: Uwe Hermann <u...@hermann-uwe.de>
diff --git a/tcl/board/at91eb40a.cfg b/tcl/board/at91eb40a.cfg
index dc5aacb..b43dee3 100644
--- a/tcl/board/at91eb40a.cfg
+++ b/tcl/board/at91eb40a.cfg
@@ -19,7 +19,6 @@ if { [info exists ENDIAN] } {
if { [info exists CPUTAPID ] } {
set _CPUTAPID $CPUTAPID
} else {
- # force an error till we get a good number
set _CPUTAPID 0x1f0f0f0f
}
diff --git a/tcl/board/mini2440.cfg b/tcl/board/mini2440.cfg
index c5adac3..a034538 100644
--- a/tcl/board/mini2440.cfg
+++ b/tcl/board/mini2440.cfg
@@ -100,7 +100,6 @@ if { [info exists ENDIAN] } {
if { [info exists CPUTAPID ] } {
set _CPUTAPID $CPUTAPID
} else {
- # force an error till we get a good number
set _CPUTAPID 0x0032409d
}
diff --git a/tcl/target/at91sam7se512.cfg b/tcl/target/at91sam7se512.cfg
index c48afef..7273a06 100644
--- a/tcl/target/at91sam7se512.cfg
+++ b/tcl/target/at91sam7se512.cfg
@@ -18,7 +18,7 @@ if { [info exists ENDIAN] } {
if { [info exists CPUTAPID ] } {
set _CPUTAPID $CPUTAPID
} else {
- # force an error till we get a good number
+ # Force an error until we get a good number.
set _CPUTAPID 0xffffffff
}
diff --git a/tcl/target/at91sam9.cfg b/tcl/target/at91sam9.cfg
index ba0197d..08154ce 100644
--- a/tcl/target/at91sam9.cfg
+++ b/tcl/target/at91sam9.cfg
@@ -17,13 +17,11 @@ if { [info exists ENDIAN] } {
if { [info exists CPUTAPID ] } {
set _CPUTAPID $CPUTAPID
} else {
- # force an error till we get a good number
set _CPUTAPID 0x0792603f
}
reset_config trst_and_srst separate trst_push_pull srst_open_drain
-#
jtag newtap $_CHIPNAME cpu -irlen 4 -ircapture 0x1 -irmask 0xf -expected-id
$_CPUTAPID
adapter_nsrst_delay 300
diff --git a/tcl/target/avr32.cfg b/tcl/target/avr32.cfg
index 7fe98b2..1a2ea33 100644
--- a/tcl/target/avr32.cfg
+++ b/tcl/target/avr32.cfg
@@ -1,7 +1,6 @@
set _CHIPNAME avr32
set _ENDIAN big
-# force an error till we get a good number
set _CPUTAPID 0x21e8203f
jtag_nsrst_delay 100
diff --git a/tcl/target/dsp56321.cfg b/tcl/target/dsp56321.cfg
index 281c4dd..74279d9 100644
--- a/tcl/target/dsp56321.cfg
+++ b/tcl/target/dsp56321.cfg
@@ -17,7 +17,6 @@ if { [info exists ENDIAN] } {
if { [info exists CPUTAPID ] } {
set _CPUTAPID $CPUTAPID
} else {
- # force an error till we get a good number
set _CPUTAPID 0x1181501d
}
diff --git a/tcl/target/dsp568013.cfg b/tcl/target/dsp568013.cfg
index 80adc76..2b25ed7 100644
--- a/tcl/target/dsp568013.cfg
+++ b/tcl/target/dsp568013.cfg
@@ -16,7 +16,6 @@ if { [info exists ENDIAN] } {
if { [info exists CPUTAPID ] } {
set _CPUTAPID $CPUTAPID
} else {
- # force an error till we get a good number
set _CPUTAPID 0x01f2401d
}
diff --git a/tcl/target/dsp568037.cfg b/tcl/target/dsp568037.cfg
index 6089e9d..21eb0b7 100644
--- a/tcl/target/dsp568037.cfg
+++ b/tcl/target/dsp568037.cfg
@@ -16,7 +16,6 @@ if { [info exists ENDIAN] } {
if { [info exists CPUTAPID ] } {
set _CPUTAPID $CPUTAPID
} else {
- # force an error till we get a good number
set _CPUTAPID 0x01f2801d
}
diff --git a/tcl/target/epc9301.cfg b/tcl/target/epc9301.cfg
index d2dc7ec..6b67b9d 100644
--- a/tcl/target/epc9301.cfg
+++ b/tcl/target/epc9301.cfg
@@ -15,7 +15,7 @@ if { [info exists ENDIAN] } {
if { [info exists CPUTAPID ] } {
set _CPUTAPID $CPUTAPID
} else {
- # force an error till we get a good number
+ # Force an error until we get a good number.
set _CPUTAPID 0xffffffff
}
diff --git a/tcl/target/is5114.cfg b/tcl/target/is5114.cfg
index 64c0c8e..56b9b65 100644
--- a/tcl/target/is5114.cfg
+++ b/tcl/target/is5114.cfg
@@ -18,7 +18,7 @@ if { [info exists ENDIAN] } {
if { [info exists CPUTAPID ] } {
set _CPUTAPID $CPUTAPID
} else {
- # force an error till we get a good number
+ # Force an error until we get a good number.
set _CPUTAPID 0xffffffff
}
diff --git a/tcl/target/pic32mx.cfg b/tcl/target/pic32mx.cfg
index efffd04..0b3522e 100644
--- a/tcl/target/pic32mx.cfg
+++ b/tcl/target/pic32mx.cfg
@@ -14,7 +14,6 @@ if { [info exists ENDIAN] } {
if { [info exists CPUTAPID ] } {
set _CPUTAPID $CPUTAPID
} else {
- # force an error till we get a good number
set _CPUTAPID 0x30938053
}
diff --git a/tcl/target/samsung_s3c2410.cfg b/tcl/target/samsung_s3c2410.cfg
index 9682c4c..73d3b50 100644
--- a/tcl/target/samsung_s3c2410.cfg
+++ b/tcl/target/samsung_s3c2410.cfg
@@ -16,6 +16,7 @@ if { [info exists ENDIAN] } {
if { [info exists CPUTAPID] } {
set _CPUTAPID $CPUTAPID
} else {
+ # Force an error until we get a good number.
set _CPUTAPID 0xffffffff
}
diff --git a/tcl/target/samsung_s3c2440.cfg b/tcl/target/samsung_s3c2440.cfg
index d3b665f..9cd27d1 100644
--- a/tcl/target/samsung_s3c2440.cfg
+++ b/tcl/target/samsung_s3c2440.cfg
@@ -19,7 +19,6 @@ if { [info exists ENDIAN] } {
if { [info exists CPUTAPID ] } {
set _CPUTAPID $CPUTAPID
} else {
- # force an error till we get a good number
set _CPUTAPID 0x0032409d
}
diff --git a/tcl/target/samsung_s3c2450.cfg b/tcl/target/samsung_s3c2450.cfg
index 0075426..164fe16 100644
--- a/tcl/target/samsung_s3c2450.cfg
+++ b/tcl/target/samsung_s3c2450.cfg
@@ -29,7 +29,6 @@ if { [info exists ENDIAN] } {
if { [info exists CPUTAPID ] } {
set _CPUTAPID $CPUTAPID
} else {
- # force an error till we get a good number
set _CPUTAPID 0x07926f0f
}
diff --git a/tcl/target/samsung_s3c6410.cfg b/tcl/target/samsung_s3c6410.cfg
index f9738c2..eb95242 100644
--- a/tcl/target/samsung_s3c6410.cfg
+++ b/tcl/target/samsung_s3c6410.cfg
@@ -23,14 +23,12 @@ if { [info exists ENDIAN] } {
if { [info exists ETBTAPID ] } {
set _ETBTAPID $ETBTAPID
} else {
- # force an error till we get a good number
set _ETBTAPID 0x2b900f0f
}
if { [info exists CPUTAPID ] } {
set _CPUTAPID $CPUTAPID
} else {
- # force an error till we get a good number
set _CPUTAPID 0x07b76f0f
}
diff --git a/tcl/target/smp8634.cfg b/tcl/target/smp8634.cfg
index 4f3959d..dc9bf0b 100644
--- a/tcl/target/smp8634.cfg
+++ b/tcl/target/smp8634.cfg
@@ -15,7 +15,6 @@ if { [info exists ENDIAN] } {
if { [info exists CPUTAPID ] } {
set _CPUTAPID $CPUTAPID
} else {
- # force an error till we get a good number
set _CPUTAPID 0x08630001
}
diff --git a/tcl/target/tmpa900.cfg b/tcl/target/tmpa900.cfg
index cfb445e..dd5d177 100644
--- a/tcl/target/tmpa900.cfg
+++ b/tcl/target/tmpa900.cfg
@@ -14,7 +14,6 @@ set _ENDIAN little
if { [info exists CPUTAPID ] } {
set _CPUTAPID $CPUTAPID
} else {
- # force an error till we get a good number
set _CPUTAPID 0x07926031
}
diff --git a/tcl/target/tmpa910.cfg b/tcl/target/tmpa910.cfg
index 4d4d3fc..271ca57 100644
--- a/tcl/target/tmpa910.cfg
+++ b/tcl/target/tmpa910.cfg
@@ -14,7 +14,6 @@ set _ENDIAN little
if { [info exists CPUTAPID ] } {
set _CPUTAPID $CPUTAPID
} else {
- # force an error till we get a good number
set _CPUTAPID 0x07926031
}
--
_______________________________________________
Openocd-development mailing list
Openocd-development@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/openocd-development
